Very minor thing, but I'm not sure about `require` calls within modules, unless there's a specific reason for them which I don't think is the case here.
These could probably be removed entirely, similar to https://github.com/openstreetmap/openstreetmap-website/pull/6461, but since it's `lib/` I'm less bothered about that. Another discussion could be had about moving everything in `lib/` to `app/lib/` as I believe that's the recommendation these days (see https://github.com/rails/rails/issues/37835#issuecomment-782843222). However perhaps some items do belong under `lib/`, if they are considered to be something that can be extracted to a gem and used by other projects. Let me know if you have thoughts. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6608 -- Commit Summary -- * Put `require` calls outside modules unless necessary -- File Changes -- M lib/osm.rb (8) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6608.patch https://github.com/openstreetmap/openstreetmap-website/pull/6608.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6608 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
