I noticed that some factory files were named in the singular and some in the plural. This PR makes it all consistent by using the singular for all.
I don't think there's a clear convention one whether to use either. To me, it makes sense to use the singular as the factories themselves are in the singular: `create(:user)`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6607 -- Commit Summary -- * Ensure all factory files named in the singular -- File Changes -- R test/factories/access_token.rb (0) R test/factories/acl.rb (0) R test/factories/changeset.rb (0) R test/factories/changeset_comment.rb (0) R test/factories/changeset_tag.rb (0) R test/factories/diary_comment.rb (0) R test/factories/diary_entry.rb (0) R test/factories/diary_entry_subscription.rb (0) R test/factories/follow.rb (0) R test/factories/issue.rb (0) R test/factories/language.rb (0) R test/factories/message.rb (0) R test/factories/node_tag.rb (0) R test/factories/note.rb (0) R test/factories/note_comment.rb (0) R test/factories/note_subscription.rb (0) R test/factories/oauth_application.rb (0) R test/factories/old_node_tag.rb (0) R test/factories/old_relation_tag.rb (0) R test/factories/old_way_tag.rb (0) R test/factories/relation_tag.rb (0) R test/factories/report.rb (0) R test/factories/trace.rb (0) R test/factories/tracepoint.rb (0) R test/factories/tracetag.rb (0) R test/factories/user_block.rb (0) R test/factories/user_preference.rb (0) R test/factories/way_tag.rb (0) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6607.patch https://github.com/openstreetmap/openstreetmap-website/pull/6607.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6607 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
