@pablobm commented on this pull request.
I think this is ok. The initial refactor and the markup-generating code make
things difficult to follow, but it can be followed a bit better when going
commit-by-commit.
If anything, the markup generation could be untangled a bit. I gave it a shot
at
https://github.com/iandees/openstreetmap-website/compare/highlight-tag-changes-in-history...pablobm:openstreetmap-website:highlight-tag-changes-in-history
and I think it's an improvement there. Not sure if it worth pursuing
elsewhere, after playing with it a bit more.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#pullrequestreview-3530490262
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6448/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
