gravitystorm left a comment (openstreetmap/openstreetmap-website#6504)

> Let's give it a day or two to see what other people think... So people can 
> see what we're talking about here's the old version:

* There's an off-by-one error on the zoom level shown. This is a common problem 
when converting things to use vector maps, since Maplibre etc have a different 
idea of what counts as zoom level X.
* The map marker should be changed to match the original leaflet marker. This 
is because we have other marker (e.g. notes, search results) that are based on 
that, and so this map should retain consistency.
* I'd like to see the button groups stay the same as other maps, again for 
consistency.

> Could this be used as an opportunity when presenting the library transition 
> to the community? Mappers can be let know that the maps with brighter markers 
> are the ones with MapLibre, and build some sort of anticipation for the 
> change to come. 

I don't think this is worth doing. Let's wait until there's something 
user-interesting (e.g. continuous zooms) before trying to make anyone aware of 
what's going on.

> (Assuming it doesn't take years!).

It was my intention that something relatively simple like this would be the 
first PR to be merged / reviewed, but my hope was also that someone would made 
a reasonable stab at ensuring the more difficult things are actually possible 
before we start down this route! If so, it shouldn't take too long, but there's 
always that risk.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#issuecomment-3597865870
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6504/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to