@tomhughes requested changes on this pull request.
In addition to the inline comments, please reorder the commits so we have Xvfb
support before the commit where we start needed it.
> with:
ruby-version: ${{ matrix.ruby }}
rubygems: 3.4.10
bundler-cache: true
+ - name: Enable virtual display & WebGL
+ run: |
+ sudo apt-get install -y xvfb mesa-utils libgl1-mesa-dri
This should just be added to the existing package install rather than running
`apt-get` twice.
> with:
ruby-version: ${{ matrix.ruby }}
rubygems: 3.4.10
bundler-cache: true
+ - name: Enable virtual display & WebGL
+ run: |
+ sudo apt-get install -y xvfb mesa-utils libgl1-mesa-dri
+ Xvfb :99 -screen 0 1024x768x24 &
+ export DISPLAY=:99
+ echo "Using virtual display $DISPLAY"
+ glxinfo | grep "OpenGL renderer" || echo "GL info not available"
These three lines are just debugging and should just be removed now you've got
it working.
This step, which will then be just the one line to start `Xvfb` should be moved
down just before the test steps that use it, and after the package install.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3497939227
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6504/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
