1ec5 left a comment (openstreetmap/openstreetmap-website#6448)
This is a smart design, makes it a lot easier to find changes at a glance. My
first impression is that we could probably even diff within a changed tag, word
by word like MediaWiki does, for more clarity. But we can always fine-tune the
presentation separately.
> I wonder if there's a way to make this work with assistive technologies too.
> An aria-* tag or something, but I can't find anything right now and it's a
> very tricky subject anyway. Perhaps for a future PR.
Along these lines, we should probably supplement the colors with some other
visual distinction, because the traffic light colors aren’t great for
colorblind friendliness. We already use these colors in the change counts in a
changeset listing, but the user can depend on the position to distinguish
between additions and deletions. Here the user can depend on deletions to be
italicized and changes to have a “→”. But nothing distinguishes an added tag
from an unchanged value. Not sure if that’s a problem with these particular
colors. We should track colorblind friendliness in a separate issue if it isn’t
trivial to deal with in this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3409084094
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6448/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
