iandees left a comment (openstreetmap/openstreetmap-website#6448)
> I see you added a background color for dark mode. To me it looks subtle
> enough not to clash with the text, so that's good. Still I wonder: is there a
> rationale for this difference?
I was experimenting but didn't mean to include this in the PR. I'll remove it.
> I wonder if there's a way to make this work with assistive technologies too.
> An aria-* tag or something, but I can't find anything right now and it's a
> very tricky subject anyway. Perhaps for a future PR.
I'm happy to explore this, but I agree that it should probably be another PR.
> The border in the middle (border-start of value cell) looks perhaps a bit too
> thin to me, particularly when contrasted with the one in the left (tag name
> cell). Probably not a big deal, but I wonder if other variants can be
> experimented.
Here's a variant where the whole row is highlighted in the color:
<img width="547" height="615" alt="image"
src="https://github.com/user-attachments/assets/ad634f9b-f245-41e1-8d40-1ecb55406406";
/>
Highlight the row with a stronger left border:
<img width="421" height="759" alt="image"
src="https://github.com/user-attachments/assets/32dbcac4-ad62-4f7c-b5c6-6e17d60f3a28";
/>
Here's one where just the value part of the table is highlighted:
<img width="436" height="786" alt="image"
src="https://github.com/user-attachments/assets/326a2d91-8cb0-4908-85b1-e34e660505db";
/>
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3408949039
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6448/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
