1ec5 left a comment (openstreetmap/openstreetmap-website#5880)
Pardon my ignorance, but could someone remind me why we wound up using inline
SVGs all over in the first place? Was there a particular benefit we were aiming
for, or is it just convenient? I see some potential tangible benefits of
separate source files:
* We can visually inspect any changes to the image directly inside GitHub’s
code review interface, just as with a PNG or JPEG. @tomhughes [doesn’t know
much about
SVG](https://github.com/openstreetmap/openstreetmap-website/pull/5884#issuecomment-2898778060),
but he should be able to take one look at the change and tell whether it’s
going to change the image size, mess with its colors, or introduce esoteric
syntax that popular SVG renderers will mangle.
* We could more easily integrate something like [SVGO](https://svgo.dev/) to
lint and optimize the SVG, minimizing the things the reviewer would have to
nitpick about more manually.
* It would promote reuse. Projects like iD have seen their icons get reused in
other projects because it’s easier to find and extract them from the project.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-3063135535
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/5880/3063135...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
