@hlfan commented on this pull request.


> +          domain: [0, heatmapData.reduce((max, item) => {
+            return item.total_changes > max ? item.total_changes : max;
+          }, 0)]

I think the 20 % performance loss is worth going for the more concise option:
```suggestion
          domain: [0, Math.max(...heatmapData.map(d => d.total_changes)), 0)]
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2705264022
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5833/review/2705264...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to