@AntonKhorev commented on this pull request.
> @@ -59,9 +60,10 @@ document.addEventListener("DOMContentLoaded", () => {
},
scale: {
color: {
- type: "threshold",
+ type: "sqrt",
+ // reverse mutates the array. But with theme changes we must work on
the original data.
What does this comment say?
If we need to stop contributors from trying `rangeColors.reverse()`
[again](https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1923048595)
and again, we can have two different `rangeColors` arrays defined earlier.
Maybe the colors in them also need to be different, not just reversed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2706077318
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5833/review/2706077...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
