@tomhughes commented on this pull request.
> @@ -139,6 +139,16 @@
<div class='text-body-secondary'>
<small>
<dl class="list-inline">
+ <% if @user.home_location_name &&
@user.home_location_name.strip.present? %>
This could just be `@user.home_location_name&.strip.present?`?
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
I don't really get what `Endpoint` means in this name? Would somethinglike
`HomeLocationGeocoder` be a better name maybe?
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
+ const endpoint = {
+ dirty: false,
What does `dirty` mean here? What is the flag mean to do? This implementing the
autofill logic described in
https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r1897207842
I think? So maybe `autofillName` or something would be a better name?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2708616016
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5302/review/2708616...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
