@AntonKhorev commented on this pull request.


> @@ -176,6 +206,64 @@ $(document).ready(function () {
     }
   }
 
+  function updateHomeLocation(updateInput = true, lat = 
$("#home_lat").val().trim(), lon = $("#home_lon").val().trim(), successFn) {

The naming here... This function is called from `respondToHomeUpdate`. 
`respondToHomeUpdate` means that "Home" was updated and we're doing something 
in response to that update. And a possible part of the response is 
`updateHomeLocation`. Wasn't "Home" updated already?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2675136734
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5302/review/2675136...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to