@tomhughes commented on this pull request.
> @@ -143,7 +143,7 @@ with making the reviews as straightforward as possible:
large to review in one sitting, or if changes are requested, then the
maintainer needs to repeatedly re-read code that has already been considered.
* The commit history is important. This is a large codebase, developed over
many
- years by many developers. We frequently need to read the commit history (e.g.
+ years by many developers. We frequently need to read the commit history
(e.g.,
Yes that's fine, can you fold that into the existing commit rather than having
me commit it as a fixup? Probably change the title of the commit as well to
remove the punctuation reference.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5637#discussion_r1949680888
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5637/review/2606822...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
