Merged, thanks.

Next we probably want to fix the bug where a note of deleted user has no 
comments because they are filtered out, but the code tries to access the first 
comment:

- changing `comments` to `all_comments` in 
https://github.com/openstreetmap/openstreetmap-website/pull/5511/commits/690d392bd866a411bed93aded9b18f884bcfcc21
- dropping either 0 or 1 comment in 
https://github.com/openstreetmap/openstreetmap-website/pull/5511/commits/0e60e2e71579dff7b7b163f08bafd278deb9caae,
 although you probably don't need to define the `author_deleted?` predicate

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5579#issuecomment-2634185487
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5579/c2634185...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to