@nenad-vujicic commented on this pull request.
> def description
- comments.first.body
+ if user_ip.nil? && user_id.nil?
+ comments.first.body
+ else
+ RichText.new("text", super)
+ end
end
> How is this PR going to go in a different direction?
Well, honestly, I don't know .. We started with one idea (simple wrappers
around `comments`) and converged to something different (`all_comments` + other
stuffs) in #5511, so I thought there is perhaps another way. Plus, I'm not sure
why #5511 is evolving so slow (I believe I messed up something, but not sure
where). It's not a problem to wait some time (how much we need) to digest these
changes and be sure they will work fine, but is that the case here (we already
have some plan + it's ~50 lines of code)?
If you are sure #5511 is proper direction, I'll be very happy to close this PR
:-)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1937480141
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5579/review/2587063...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
