> I do wonder how it interacts with comments though - do we duplicate those for 
> every version like we do with members of other objects or do we always show 
> all comments whatever the version or maybe track add the current version to 
> the comment when it's created and then show comments up to the note's version 
> when showing an old version of the note?

I wouldn't say "duplicate (comments) for every version like we do with members 
of other objects" - do we even have comments for versioned objects elsewhere?

The idea is to take the current comments, let's call them *api 0.6 comments*, 
and split them into actual comments and versions. Versions will contain states 
(open/closed/hidden) that were previously in api 0.6 comments. After that it 
should be possible to reassemble actual comments and versions into api 0.6 
comments for use in api calls. This reassembling wouldn't require associating 
comments with versions if I'm correct.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#issuecomment-2589853554
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5485/c2589853...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to