@AntonKhorev commented on this pull request.
> + border_type = t
> "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}",
> :default => prefix_name if extratag.attributes["key"] == "border_type"
+ place_type = t
"geocoder.search_osm_nominatim.prefix.place.#{extratag.attributes['value']}",
:default => prefix_name if extratag.attributes["key"] == "linked_place" ||
extratag.attributes["key"] == "place"
Shouldn't `:default` be `border_type` and `place_type` correspondingly, given
that later the values are combined with `place_type || border_type ||
prefix_name`?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545563214
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5493/review/2545563...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
