@1ec5 commented on this pull request.


> +          border_type = t 
> "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}", 
> :default => prefix_name if extratag.attributes["key"] == "border_type"
+          place_type = t 
"geocoder.search_osm_nominatim.prefix.place.#{extratag.attributes['value']}", 
:default => prefix_name if extratag.attributes["key"] == "linked_place" || 
extratag.attributes["key"] == "place"

Yes, good catch. I originally had two loops that set `prefix_name` directly. 
Now we probably don’t need a `:default` at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#discussion_r1912575079
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5493/review/2545564...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to