- Add test that would have failed in #5359. - Change the code that selects the text input from `$("textarea")` to `content.find("textarea")`. This should stop the html share code from getting posted to notes, although I couldn't reproduce that happening like @SomeoneElseOSM reported it yesterday. When you press *Hide* the textarea inside the left sidebar exists and is the first one on the page, I don't know how that other textarea got selected instead. You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5419 -- Commit Summary -- * Test share textarea not to leak into note text on reactivation * Get note text only from textarea within left sidebar * Move blocked resolve/reactivate tests to ResolveNoteTest * Use within_sidebar in CreateNoteTest -- File Changes -- M app/assets/javascripts/index/note.js (2) M test/system/create_note_test.rb (16) M test/system/note_comments_test.rb (46) A test/system/resolve_note_test.rb (106) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5419.patch https://github.com/openstreetmap/openstreetmap-website/pull/5419.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5419 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
