What the existing share popup window placement does is it places the popup horizontally in the center of the screen. I don't know if the popup can get placed literally in the corner (https://github.com/openstreetmap/openstreetmap-website/issues/5414#issuecomment-2551615977), maybe with a multi-monitor setup? But it still could be a surprising location if the monitor is large enough. Here the logic is changed to place the popup in the center of the browser window. Is it less surprising?
The only alternative to a popup window is a new tab, which is already available with middle click or context menu on share links. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5418 -- Commit Summary -- * Center share popup inside the browser window -- File Changes -- M app/assets/javascripts/social_share_button.js (4) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5418.patch https://github.com/openstreetmap/openstreetmap-website/pull/5418.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5418 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
