This implements the refactorings suggested in #5415 and also improves the testing of the generated HTML to ensure that all the buttons are generated and reference the correct URL and title. You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5417 -- Commit Summary -- * Drop render prefix from social_share_buttons function * Drop unused ability to filter social sharing sites * Drop unused options from social_share_buttons * Use safe_join to join social sharing buttons * Improve testing of social sharing buttons -- File Changes -- M app/helpers/social_share_button_helper.rb (58) M app/views/diary_entries/show.html.erb (5) M test/helpers/social_share_button_helper_test.rb (35) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5417.patch https://github.com/openstreetmap/openstreetmap-website/pull/5417.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5417 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
