@grekko commented on this pull request.
> @@ -39,6 +49,10 @@ class Note < ApplicationRecord
DEFAULT_FRESHLY_CLOSED_LIMIT = 7.days
+ def comments_with_extra_open_comment
> The API can use the first two to make the legacy-first-comment.
Ah ok. You'd rather have the logic in the API controller, instead of hidden in
a Model-method, correct?
That's ok for me. I'll rewrite the PR to reflect this.
> Partly this depends on the data migration strategy - whether we expect to do
> one of the two following options […]
I understand you lean towards the latter option – backfilling data and removing
the first comment in 1 atomic operation. That should simplify the code as well
I think. I'll adjust the PR to match this behaviour.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#discussion_r1790139682
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/4481/review/2351819...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
