--- Begin Message ---
Just a few comments:
- Given vioplot 0.2 is 12 years old, I wouldn't be TOO concerned with backward
compatibility. I wouldn't ignore it either, but if I had to choose, I'd go for
modern idioms over ensuring that everything works exactly the same.
- You don't need to keep HTML versions of the vignettes in the repo. They'll be
built automatically from the Rmd files when you run
install.packages("vioplot"). Also, if size is an issue, you can set output:
rmarkdown::html_vignette instead of rmarkdown::html_document which reduces the
output size considerably.
- Using attach() to evaluate a formula in the context of a data frame should
never be necessary; use model.frame(*, data=df) or eval(*, envir=df). That
said, I didn't see any uses of attach in the repo, so presumably you've already
fixed this.
- BSD is a very permissive license. While I'm not a lawyer, I don't think there
would be any conflicts if you changed it to, say, the MIT license which is also
very permissive.
-----Original Message-----
From: R-package-devel <r-package-devel-boun...@r-project.org> On Behalf Of Tom
Kelly
Sent: Wednesday, 26 December, 2018 7:01 PM
To: cran-submissi...@r-project.org; r-package-devel@r-project.org
Subject: [R-pkg-devel] Fwd: [CRAN-pretest-archived] CRAN submission vioplot
0.3.0
Dear CRAN maintainers and R package developers,
I am still interested in submitting this update to the "vioplot" package. I
would like to revisit the idea to update this package on CRAN. I think the
changes that I've made here would be useful to a significant number of R users.
I am submitting to take over as maintainer as this package has been orphaned
for years. I will of course take measures to attribute the original author and
preserve the original LICENSE.
This is a major update with many additional features. This includes fine
control over plotting parameters and formula inputs with documentation on these
parameters. I've added tests and vignettes showing that these work.
However, it does not pass automated checks such as the LICENSE since some
aspects of the original package are very outdated (the additional NOTEs from
the CRAN checks were due to the outdated LICENSE and not being the current
maintainer). Thus a manual review would be required. Otherwise, I have taken
every measure I think is possible to reduce the number of errors from automated
checks and ensure backwards compatibility. These additional features can be
pushed to the repo without disrupting the behaviour of any existing scripts or
packages calling this function.
I realise that the files may since been removed and I would need to resubmit if
it is possible. These can be found at the following GitHub repo:
https://github.com/TomKellyGenetics/vioplot
Kind regards,
Tom Kelly
---------- Forwarded message ---------
From: Tom Kelly <tomkellygenet...@gmail.com>
Date: Sun, Feb 25, 2018 at 10:33 AM
Subject: Re: [CRAN-pretest-archived] CRAN submission vioplot 0.3.0
To: <cran-submissi...@r-project.org>
Cc: Tom Kelly <tom.ke...@postgrad.otago.ac.nz>
Dear CRAN team,
I have documented the NOTE issues in a cran-comments.md file. I think some of
these are unavoidable as stated in this file. In particular, some issues with
automated checks may arise due to legacy code and meta-data for compatibility
with vioplot 0.2 (last updated in 2005). Please notice that many of the checks
failed by the original package vioplot 0.2 have been resolved with this
release. In addition, this supports range of added features and input methods
consistent with similar plotting functions while preserving
backwards-compatibility.
Due to the proposal to take over as maintainer of an orphaned package, I
request that this submission be reviewed manually. Sorry for the inconvenience,
I will do my best to resolve any further issues that should arise.
Kind Regards,
Tom Kelly
On Sun, Feb 25, 2018 at 12:34 AM, <uwe.lig...@r-project.org> wrote:
> Dear maintainer,
>
> package vioplot_0.3.0.tar.gz does not pass the incoming checks
> automatically, please see the pre-test at:
> <
> https://win-builder.r-project.org/incoming_pretest/180224_163015_viopl
> ot_030/00check.log
> >
> Status: 5 NOTEs
>
> Current CRAN status: NOTE: 12
> See:
> <https://CRAN.R-project.org/web/checks/check_results_vioplot.html>
>
> Please fix all problems and resubmit a fixed version via the webform.
> If you are not sure how to fix the problems shown, please ask for help
> on the R-package-devel mailing list:
> <https://stat.ethz.ch/mailman/listinfo/r-package-devel>
> If you are fairly certain the rejection is a false positive, please
> reply-all to this message and explain.
>
> More details are given in the directory:
> <
> https://win-builder.r-project.org/incoming_pretest/180224_163015_viopl
> ot_030
> >
> The files will be removed after roughly 7 days.
>
> Strong rev. depends: parviol regplot
>
> Best regards,
> CRAN teams' auto-check service
>
>
[[alternative HTML version deleted]]
______________________________________________
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
--- End Message ---
______________________________________________
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
