On 26/12/2018 3:00 a.m., Tom Kelly wrote:
Dear CRAN maintainers and R package developers,
I am still interested in submitting this update to the "vioplot" package. I
would like to revisit the idea to update this package on CRAN. I think the
changes that I've made here would be useful to a significant number of R
users.
I am submitting to take over as maintainer as this package has been
orphaned for years. I will of course take measures to attribute the
original author and preserve the original LICENSE.
This is a major update with many additional features. This includes fine
control over plotting parameters and formula inputs with documentation on
these parameters. I've added tests and vignettes showing that these work.
However, it does not pass automated checks such as the LICENSE since some
aspects of the original package are very outdated (the additional NOTEs
from the CRAN checks were due to the outdated LICENSE and not being the
current maintainer). Thus a manual review would be required. Otherwise, I
have taken every measure I think is possible to reduce the number of errors
from automated checks and ensure backwards compatibility. These additional
features can be pushed to the repo without disrupting the behaviour of any
existing scripts or packages calling this function.
I realise that the files may since been removed and I would need to
resubmit if it is possible. These can be found at the following GitHub repo:
https://github.com/TomKellyGenetics/vioplot
CRAN has announced they are taking a (well-deserved) holiday, and not
processing incoming packages until after Jan 2. The check log from your
February submission is long since removed, so I can't give specific
comments, but here are some general ones:
1. Check your package using the "as-cran" option on R-devel before
submitting again. Make sure that the only remaining problems are
unavoidable: e.g. including your name as maintainer. You should be
able to fix the License issue following the instructions in Writing R
Extensions, if the license really is compatible with CRAN. If it is not
compatible with CRAN, then don't waste everyone's time by submitting it
there: let interested people install it from Github.
2. Submit it again after Jan 2, following the instructions in
https://cran.r-project.org/web/packages/policies.html.
Duncan Murdoch
Kind regards,
Tom Kelly
---------- Forwarded message ---------
From: Tom Kelly <tomkellygenet...@gmail.com>
Date: Sun, Feb 25, 2018 at 10:33 AM
Subject: Re: [CRAN-pretest-archived] CRAN submission vioplot 0.3.0
To: <cran-submissi...@r-project.org>
Cc: Tom Kelly <tom.ke...@postgrad.otago.ac.nz>
Dear CRAN team,
I have documented the NOTE issues in a cran-comments.md file. I think some
of these are unavoidable as stated in this file. In particular, some issues
with automated checks may arise due to legacy code and meta-data for
compatibility with vioplot 0.2 (last updated in 2005). Please notice that
many of the checks failed by the original package vioplot 0.2 have been
resolved with this release. In addition, this supports range of added
features and input methods consistent with similar plotting functions while
preserving backwards-compatibility.
Due to the proposal to take over as maintainer of an orphaned package, I
request that this submission be reviewed manually. Sorry for the
inconvenience, I will do my best to resolve any further issues that should
arise.
Kind Regards,
Tom Kelly
On Sun, Feb 25, 2018 at 12:34 AM, <uwe.lig...@r-project.org> wrote:
Dear maintainer,
package vioplot_0.3.0.tar.gz does not pass the incoming checks
automatically, please see the pre-test at:
<
https://win-builder.r-project.org/incoming_pretest/180224_163015_vioplot_030/00check.log
Status: 5 NOTEs
Current CRAN status: NOTE: 12
See: <https://CRAN.R-project.org/web/checks/check_results_vioplot.html>
Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on
the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please
reply-all to this message and explain.
More details are given in the directory:
<
https://win-builder.r-project.org/incoming_pretest/180224_163015_vioplot_030
The files will be removed after roughly 7 days.
Strong rev. depends: parviol regplot
Best regards,
CRAN teams' auto-check service
[[alternative HTML version deleted]]
______________________________________________
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
______________________________________________
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
