Matt Simerson wrote: > > > On May 9, 2010, at 11:30 PM, Robert Spier wrote: > > > Applied manually to my tree as > > e8cb1c3e94c9effc596aafb0442434d07098fc5d > > > > another mangled patch. > > I'm new to git, so I've been creating and emailing the patches per the > instructions in docs/development.pod. But apparently there's something > I'm not doing right. > > I created the patches using git format-patch, which leaves the 000* > files in my git directory. Then I emailed to myself with git send- > email', cleaned up/shortened the subject (I belatedly realized that I > don't want to 'bundle' long descriptions in there), and then forwarded > them to the list. Should I send them directly to the list via 'git > send-email'?
Yes, if you can make that work properly. If you can't, try sending the patches as attachments, instead of inline to the message. > > > General comments: > > Please try and limit lines to 80 characters. > > Should we add that to .perltidyrc? > > -l=80 # Max line width is 80 cols IMHO, yes. > > > Please try and make the first line of the patch description short > > (iirc, git likes <60 characters) and then use the 3rd and further > > lines for explanation.) > > If I'm understanding you correctly, the following patch should embody > what you just described. Right? > > Matt > > > diff --git a/docs/development.pod b/docs/development.pod > index f991942..717246d 100644 > --- a/docs/development.pod > +++ b/docs/development.pod > @@ -52,10 +52,15 @@ When you're ready to check it in... > git add lib/Qpsmtpd.pm # to let git know you changed the file > git add --patch plugin/tls # interactive choose which changes to add > git diff --cached # review changes added > - git commit > + git commit # see 'Git commit notes' section > git log -p # review your commit a last time > git push origin # to send to github > > +=head3 Git commit notes > + > +Make the first line of the patch description short (git likes <60 > chars). > +Use the 3rd and further lines for explanation. > + > =head3 Submit patches by mail Yes. I've just committed http://github.com/rspier/qpsmtpd/commit/3939c7bc514acf487f56a4893dbcbb28abbb1ade which has a more verbose version, from git-commit(1). Though not required, it's a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. Tools that turn commits into email, for example, use the first line on the Subject: line and the rest of the commit in the body. (From: L<git-commit(1)>) -R
