Applied manually to my tree as e8cb1c3e94c9effc596aafb0442434d07098fc5d
another mangled patch.
General comments:
Please try and limit lines to 80 characters.
Please try and make the first line of the patch description short
(iirc, git likes <60 characters) and then use the 3rd and further
lines for explanation.)
Matt Simerson wrote:
>
> added defined test to $local_port. It was emitting errors due to not
> being defined. My previous commit to TcpServer.pm fixed the definition
> problem, this suppresses the error.
>
> ---
> plugins/tls | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/tls b/plugins/tls
> index 875bacf..ee8a5d4 100644
> --- a/plugins/tls
> +++ b/plugins/tls
> @@ -148,7 +148,7 @@ sub hook_connect {
> my ($self, $transaction) = @_;
>
> my $local_port = $self->qp->connection->local_port;
> - return DECLINED unless $local_port == 465; # SMTPS
> + return DECLINED unless (defined $local_port && $local_port ==
> 465); # SMTPS
>
> unless (_convert_to_ssl($self)) {
> return (DENY_DISCONNECT, "Cannot establish SSL session");
> --
> 1.7.0.6
>
