On 31/07/09 08:19, Ask Bjørn Hansen wrote: > > On Jul 30, 2009, at 16:13, Robin Bowes wrote: > > Thanks for working on this Robin. > > A couple of comments: > > Could the VERSION stuff not be hardcoded?
It could. It's done this way so the Makefile is generic, ie. it can be used with any project without changes. Actually, that's not strictly true - SCM_PATH is hard-coded; the Makefile was designed to be dropped in the root of the repository. > > It looks like qpsmtpd.spec and qpsmtpd.spec.in is the same, is that right? They are in this case, but when working with an svn repo, it appends the revision no. to the release string. Again, the result of the generic Makefile. > Would it be possible to make so making the .tar.gz will (with the > regular perl Makefile.PL; make dist commands) would generate the .spec > file in some location and way so 'rpmbuild -ta qpsmtpd-0.83.tar.gz' > would generate the rpms? (So basically generate the qpsmtpd.spec file > as part of "make dist"; I guess). I don't know. If the tarball has a spec file in it (not sure where it has to be - in the root??) then rpmbuild -ba should work OK. So it may be that all we need to do is move qpsmtpd.spec to the repo root, and hardcode the version stuff, and it will Just Work. > On a sidenote: In general then it's best to do new work on a "topic > branch" branched from some point in my master and then not merge. It > makes the code easier to review (and to merge). I don't know what that means - /me does not grok git yet. :) > Linus had some notes on this earlier this year (apologies if I posted > them already): > http://www.mail-archive.com/dri-de...@lists.sourceforge.net/msg39091.html If you did, I haven't read them! Thanks, R.
