On Jul 30, 2009, at 16:13, Robin Bowes wrote:
Thanks for working on this Robin.
A couple of comments:
Could the VERSION stuff not be hardcoded?
It looks like qpsmtpd.spec and qpsmtpd.spec.in is the same, is that
right?
Would it be possible to make so making the .tar.gz will (with the
regular perl Makefile.PL; make dist commands) would generate the .spec
file in some location and way so 'rpmbuild -ta qpsmtpd-0.83.tar.gz'
would generate the rpms? (So basically generate the qpsmtpd.spec file
as part of "make dist"; I guess).
On a sidenote: In general then it's best to do new work on a "topic
branch" branched from some point in my master and then not merge. It
makes the code easier to review (and to merge).
Linus had some notes on this earlier this year (apologies if I posted
them already):
http://www.mail-archive.com/dri-de...@lists.sourceforge.net/msg39091.html
- ask
