Matt Sergeant wrote:
> 
> On Mon, 28 Jul 2008 20:47:39 -0400, Brian Szymanski wrote:
> > Then let's make that diff instead - remove all the "use
> > Qpsmtpd::Constants" in plugins, and add your test harness?
> 
> I agree. Make your tester run the same code in Qpsmtpd.pm (or is it now 
> in Plugin.pm, I don't recall) that compiles the plugins and checks the 
> status.

I'm actually +1 on making the plugins more syntactically correct.
It's really useful to be able to just run perl -c on them.    I don't
see a downside.

Putting complex logic in the tester, or duplicating that logic is a
bad idea.
 

Reply via email to