On Mon Jul 28, 2008 at 17:24:59 -0400, Brian Szymanski wrote:
> What real errors would your diffs catch? The one case you showed
> involved a false positive.
With the assumption that you run "make test" prior to commiting
then it would catch a genuine syntax error. Such as the
following which I introduced into uribl:
my %strict_twolevel_cctlds = (
'ac' => 1,
+ 'ae' => 1
- 'ae' => 1,
'uk' => 1,
(i.e. I removed a trailing comma in a hasty edit, and didn't
realize until I committed the plugin to my master site and updated
all my MX machines.)
> Why not let the test script use Qpsmtpd::Constants and anything else all
> plugins use, instead of adding a line to each plugin in the universe
> (many if not most of which are third party and out of control of svn
> anyway)?
That is of course the simpler solution.
Adding the constant usage is basically a trivial change that isn't
required. But if you are in the habit of syntax testing your modules
regularly (which I wasn't) or running test cases (which I am) then it
does give you increase coverage. Not much I grant you. But some.
Steve
--
