> On 16 Oct 2023, at 10:01, Miguel Luis <miguel.l...@oracle.com> wrote: > > Hi Salil, > >> On 16 Oct 2023, at 09:52, Salil Mehta <salil.me...@huawei.com> wrote: >> >> Hi Miguel, >> >>> From: Miguel Luis <miguel.l...@oracle.com> >>> Sent: Friday, October 13, 2023 5:34 PM >>> To: Salil Mehta <salil.me...@huawei.com> >>> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc Zyngier >>> <m...@kernel.org>; jean-phili...@linaro.org; Jonathan Cameron >>> <jonathan.came...@huawei.com>; lpieral...@kernel.org; Peter Maydell >>> <peter.mayd...@linaro.org>; Richard Henderson >>> <richard.hender...@linaro.org>; imamm...@redhat.com; >>> andrew.jo...@linux.dev; da...@redhat.com; phi...@linaro.org; >>> eric.au...@redhat.com; oliver.up...@linux.dev; pbonz...@redhat.com; >>> m...@redhat.com; w...@kernel.org; gs...@redhat.com; raf...@kernel.org; >>> alex.ben...@linaro.org; li...@armlinux.org.uk; >>> dar...@os.amperecomputing.com; il...@os.amperecomputing.com; >>> vis...@os.amperecomputing.com; Karl Heubaum <karl.heub...@oracle.com>; >>> salil.me...@opnsrc.net; zhukeqian <zhukeqi...@huawei.com>; wangxiongfeng >>> (C) <wangxiongfe...@huawei.com>; wangyanan (Y) <wangyana...@huawei.com>; >>> jiakern...@gmail.com; maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm >>> <linux...@huawei.com> >>> Subject: Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU >>> Hotplug >>> >>> Hi Salil, >>> >>>> On 13 Oct 2023, at 10:51, Salil Mehta <salil.me...@huawei.com> wrote: >>>> >>>> Virtual CPU hotplug support is being added across various >>> architectures[1][3]. >>>> This series adds various code bits common across all architectures: >> >> >> [...] >> >> >>> I tested it for Arm64, make check, boot/reboot, live migration and found no >>> issues, >>> so for this, please feel free to add: >>> >>> Tested-by: Miguel Luis <miguel.l...@oracle.com> >> >> Great. Many thanks for the confirmation. >> >> I guess you are repeating the same for x86 as well? >> > > You are welcome! > > Absolutely, I’m repeating those same tests for x86. >
Unfortunately, there's a qtest failing for x86. The failing test is device-introspect-test in which the assert for mc->possible_cpu_arch_ids fails. There’s also a suggestion to fix it here: https://lore.kernel.org/qemu-devel/15e70616-6abb-63a4-17d0-820f4a254...@opnsrc.net/T/#m108f102b2fe92b7dd7218f2f942f7b233a9d6af3 Thanks, Miguel > Thanks > Miguel > >> Salil.