On 1 March 2012 08:22, Andreas Färber <afaer...@suse.de> wrote: > Am 28.02.2012 04:13, schrieb Evgeny Voevodin: >> On 27.02.2012 16:35, Peter Maydell wrote: >>> A true multithreaded TCG is a large project, and unless we're >>> going to commit to doing that I don't see much value in making >>> some variables per-thread when we might instead need to do >>> larger refactorings (properly encapsulating the codegen >>> caches as qom objects, maybe?). >> >> [...] qomification of translation caches is an interesting suggestion I >> think. > > While I have come to like QOM and am using it for the CPUState, I don't > see the benefit in using it for these secondary structures. There are > already dedicated monitor commands to inspect them, no?
Mostly I was thinking about the encapsulation of knowing which data structures are associated with a translation cache and letting you have more than one of them. You could do that with a plain struct but since we have this OO infrastructure now why not use it? -- PMM
