On 12/10/23 15:07, Philippe Mathieu-Daudé wrote:
On 14/7/23 08:58, Richard Henderson wrote:
On 7/10/23 18:50, Philippe Mathieu-Daudé wrote:
+static void pl011_write_txdata(PL011State *s, const uint8_t *buf,
int length)
+{
+ /* ??? Check if transmitter is enabled. */
+
+ /* XXX this blocks entire thread. Rewrite to use
+ * qemu_chr_fe_write and background I/O callbacks */
+ qemu_chr_fe_write_all(&s->chr, buf, 1);
Not using length?
This is a simple "code extract" patch. Length is used when
we switch to FIFO in the last patch.
Hmm you are right it isn't used...
The UARTDR register is 16-bit wide. Only 8 bits are used for data.
No need for a 'length' param here.
