On 09.10.23 15:49, Salil Mehta wrote:
From: David Hildenbrand <da...@redhat.com>
Sent: Monday, October 9, 2023 1:23 PM
To: Salil Mehta <salil.me...@huawei.com>; qemu-devel@nongnu.org; qemu-
a...@nongnu.org
Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
<jonathan.came...@huawei.com>; lpieral...@kernel.org;
peter.mayd...@linaro.org; richard.hender...@linaro.org;
imamm...@redhat.com; andrew.jo...@linux.dev; phi...@linaro.org;
eric.au...@redhat.com; oliver.up...@linux.dev; pbonz...@redhat.com;
m...@redhat.com; w...@kernel.org; gs...@redhat.com; raf...@kernel.org;
alex.ben...@linaro.org; li...@armlinux.org.uk;
dar...@os.amperecomputing.com; il...@os.amperecomputing.com;
vis...@os.amperecomputing.com; karl.heub...@oracle.com;
miguel.l...@oracle.com; salil.me...@opnsrc.net; zhukeqian
<zhukeqi...@huawei.com>; wangxiongfeng (C) <wangxiongfe...@huawei.com>;
wangyanan (Y) <wangyana...@huawei.com>; jiakern...@gmail.com;
maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm <linux...@huawei.com>
Subject: Re: [PATCH V3 03/10] hw/acpi: Add ACPI CPU hotplug init stub
On 09.10.23 13:28, Salil Mehta wrote:
ACPI CPU hotplug related initialization should only happen if
ACPI_CPU_HOTPLUG
support has been enabled for particular architecture. Add
cpu_hotplug_hw_init()
stub to avoid compilation break.
Signed-off-by: Salil Mehta <salil.me...@huawei.com>
Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
Reviewed-by: Gavin Shan <gs...@redhat.com>
---
hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-
stub.c
index 3fc4b14c26..c6c61bb9cd 100644
--- a/hw/acpi/acpi-cpu-hotplug-stub.c
+++ b/hw/acpi/acpi-cpu-hotplug-stub.c
@@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion
*parent, Object *owner,
return;
}
+void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
+ CPUHotplugState *state, hwaddr base_addr)
+{
+ return;
+}
While at it, can we prefix that function with acpi?
I can do that but it has to be done at other places as well
such as in hw/acpi/cpu_hotplug.c <acpi_switch_to_modern_cphp()>
$ git grep cpu_hotplug_hw_init
hw/acpi/cpu.c:void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
hw/acpi/cpu_hotplug.c: cpu_hotplug_hw_init(parent, gpe_cpu->device,
cpuhp_state, io_port);
include/hw/acpi/cpu.h:void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
Might want to do that as a separate patch, agreed.
--
Cheers,
David / dhildenb
