Warner Losh <i...@bsdimp.com> writes: > On Fri, Oct 6, 2023, 11:55 AM Thomas Huth <th...@redhat.com> wrote: > >> On 06/10/2023 18.18, Thomas Huth wrote: >> > On 06/10/2023 16.45, Markus Armbruster wrote: >> >> Local variables shadowing other local variables or parameters make the >> >> code needlessly hard to understand. Bugs love to hide in such code. >> >> Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail >> >> on polling error". >> >> >> >> Enabling -Wshadow would prevent bugs like this one. But we have to >> >> clean up all the offenders first. >> >> >> >> Quite a few people responded to my calls for help. Thank you so much! >> >> >> >> I'm collecting patches in my git repo at >> >> https://repo.or.cz/qemu/armbru.git in branch shadow-next. All but the >> >> last two are in a pending pull request.
[...] >> >> More warnings may lurk in code my test build doesn't compile. Need a >> >> full CI build with -Wshadow=local to find them. Anybody care to kick >> >> one off? >> > >> > I ran a build here (with -Werror enabled, so that it's easier to see where >> > it breaks): >> > >> > https://gitlab.com/thuth/qemu/-/pipelines/1028023489 >> > >> > ... but I didn't see any additional spots in the logs beside the ones that >> > you already listed. >> >> After adding two more patches to fix the above warnings, things look >> pretty >> good: >> >> https://gitlab.com/thuth/qemu/-/pipelines/1028413030 >> >> There are just some warnings left in the BSD code, as Warner already >> mentioned in his reply to v2 of your mail: >> >> https://gitlab.com/thuth/qemu/-/jobs/5241420713 > > > I think I have fixes for these. I need to merge what just landed into > bsd-user fork, rebase, test, the apply them to qemu master branch, retest > and send them off... > > My illness has hung on longer than I thought so I'm still behind... Get well, and looking forward to your patches!
