Markus Armbruster <arm...@redhat.com> writes: > qemu_rdma_dump_id() dumps RDMA device details to stdout. > > rdma_start_outgoing_migration() calls it via qemu_rdma_source_init() > and qemu_rdma_resolve_host() to show source device details. > rdma_start_incoming_migration() arranges its call via > rdma_accept_incoming_migration() and qemu_rdma_accept() to show > destination device details. > > Two issues: > > 1. rdma_start_outgoing_migration() can run in HMP context. The > information should arguably go the monitor, not stdout. > > 2. ibv_query_port() failure is reported as error. Its callers remain > unaware of this failure (qemu_rdma_dump_id() can't fail), so > reporting this to the user as an error is problematic. > > Fixable, but the device detail dump is noise, except when > troubleshooting. Tracing is a better fit. Similar function > qemu_rdma_dump_id() was converted to tracing in commit > 733252deb8b (Tracify migration/rdma.c). > > Convert qemu_rdma_dump_id(), too. > > While there, touch up qemu_rdma_dump_gid()'s outdated comment. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Fabiano Rosas <faro...@suse.de>
