Re: [PATCH v2 02/11] target/tricore: Implement CRCN insn

[Richard Henderson]

On 8/28/23 04:26, Bastian Koppelmann wrote:

reported inhttps://gitlab.com/qemu-project/qemu/-/issues/1667

Signed-off-by: Bastian Koppelmann<kbast...@mail.uni-paderborn.de>
---
v1 -> v2:
     - Removed useless deposits in crc_div()
     - Replaced final deposit() with extract() in helper_crcn()
     - Add trap for CRCN insn if not feature_162

  target/tricore/helper.h                   |  1 +
  target/tricore/op_helper.c                | 63 +++++++++++++++++++++++
  target/tricore/translate.c                |  8 +++
  target/tricore/tricore-opcodes.h          |  1 +
  tests/tcg/tricore/Makefile.softmmu-target |  1 +
  tests/tcg/tricore/asm/test_crcn.S         |  9 ++++
  6 files changed, 83 insertions(+)
  create mode 100644 tests/tcg/tricore/asm/test_crcn.S

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~