Volker Rümelin <vr_q...@t-online.de> writes:
> Am 21.08.23 um 08:06 schrieb Manos Pitsidianakis: > > Hello Volker! > > On Sun, 20 Aug 2023 12:33, Volker Rümelin <vr_q...@t-online.de> wrote: > > I think the virtio-snd.c code, the trace events and the Kconfig VIRTIO_SND > should be moved to hw/audio. The > code for nearly all audio devices is in this directory. This would be > similar to other virtio devices. E.g. the > virtio-scsi code is in hw/scsi and the virtio-net code is in hw/net. > > This was where it was initially but in previous patchset versions it was > recommended to move them to hw/virtio. I > don't mind either approach though. > > Hi Manos, > > Ok, then don't change the directory. I guess I will have to discuss > this with Alex first. Yeah we are not super consistent about this in the code base. There are a whole class of VirtIO devices which are either stubs for vhost-user or not the usual block/net devices where hw/virtio makes the most sense to keep things together. Things like virtio-block and -net often share or integrate more closely with their sub-systems so that certainly makes an argument for including them in the respective subdirs. You also get arch specific virtio devices (e.g. s390x ccw devices) which live in the hw/$ARCH directories. I would certainly argue they should all share the include/hw/virtio directory for their type and structure definitions. Whether virtio-sound deserves to be with the rest of the sound HW I guess depends on if it makes things easier to integrate? There will be a vhost-user-sound device at some point and that won't require integration with QEMU's internal sound APIs. mst what do you think? -- Alex Bennée Virtualisation Tech Lead @ Linaro
