QE tested v3 of this series using the test steps provided by Hawkins and everything works fine.
Tested-by: Lei Yang <leiy...@redhat.com> On Sun, Jul 23, 2023 at 8:10 PM Hawkins Jiawei <yin31...@gmail.com> wrote: > > This series enables shadowed CVQ to intercept VLAN commands > through shadowed CVQ, update the virtio NIC device model > so qemu send it in a migration, and the restore of that > VLAN state in the destination. > > ChangeLog > ========= > v3: > - remove the extra "From" line in patch 1 > "virtio-net: do not reset vlan filtering at set_features" > > v2: https://lore.kernel.org/all/cover.1690100802.git.yin31...@gmail.com/ > - remove the extra line pointed out by Eugenio in patch 3 > "vdpa: Restore vlan filtering state" > > v1: https://lore.kernel.org/all/cover.1689690854.git.yin31...@gmail.com/ > - based on patch "[PATCH 0/3] Vhost-vdpa Shadow Virtqueue VLAN support" > at https://lists.gnu.org/archive/html/qemu-devel/2022-09/msg01016.html > - move `MAX_VLAN` macro to include/hw/virtio/virtio-net.h > instead of net/vhost-vdpa.c > - fix conflicts with the master branch > > > TestStep > ======== > 1. test the migration using vp-vdpa device > - For L0 guest, boot QEMU with two virtio-net-pci net device with > `ctrl_vq`, `ctrl_vlan` features on, command line like: > -device virtio-net-pci,disable-legacy=on,disable-modern=off, > iommu_platform=on,mq=on,ctrl_vq=on,guest_announce=off, > indirect_desc=off,queue_reset=off,ctrl_vlan=on,... > > - For L1 guest, apply the patch series and compile the source code, > start QEMU with two vdpa device with svq mode on, enable the `ctrl_vq`, > `ctrl_vlan` features on, command line like: > -netdev type=vhost-vdpa,x-svq=true,... > -device virtio-net-pci,mq=on,guest_announce=off,ctrl_vq=on, > ctrl_vlan=on,... > > - For L2 source guest, run the following bash command: > ```bash > #!/bin/sh > > for idx in {1..4094} > do > ip link add link eth0 name vlan$idx type vlan id $idx > done > ``` > > - gdb attaches the L2 dest VM and break at the > vhost_vdpa_net_load_single_vlan(), and execute the following > gdbscript > ```gdbscript > ignore 1 4094 > c > ``` > > - Execute the live migration in L2 source monitor > > - Result > * with this series, gdb can hit the breakpoint and continue > the executing without triggering any error or warning. > > Eugenio Pérez (1): > virtio-net: do not reset vlan filtering at set_features > > Hawkins Jiawei (3): > virtio-net: Expose MAX_VLAN > vdpa: Restore vlan filtering state > vdpa: Allow VIRTIO_NET_F_CTRL_VLAN in SVQ > > hw/net/virtio-net.c | 6 +---- > include/hw/virtio/virtio-net.h | 6 +++++ > net/vhost-vdpa.c | 49 ++++++++++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+), 5 deletions(-) > > -- > 2.25.1 > >
