Re: [RFC][PATCH] accel/tcg: Use lookup_and_goto_ptr() for linux-user in translator_use_goto_tb()

[Richard Henderson]

On 7/30/23 10:56, Helge Deller wrote:

+++ b/accel/tcg/translator.c
@@ -124,8 +124,13 @@ bool translator_use_goto_tb(DisasContextBase *db, vaddr 
dest)
          return false;
      }

+#ifndef CONFIG_USER_ONLY
      /* Check for the dest on the same page as the start of the TB.  */
      return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0;
+#else
+    /* linux-user doesn't need to fear pagefaults for exec swap-in */
+    return false;
+#endif
  }

No, we still need to stop at pages for breakpoints.


r~