Re: [PATCH v2] block/file-posix: fix g_file_get_contents return path

[Stefan Hajnoczi]

On Thu, Jul 27, 2023 at 01:15:32PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 27, 2023 at 07:58:44PM +0800, Sam Li wrote:
> > The g_file_get_contents() function returns a g_boolean. If it fails, the
> > returned value will be 0 instead of -1. Solve the issue by skipping
> > assigning ret value.
> > 
> > This issue was found by Matthew Rosato using virtio-blk-{pci,ccw} backed
> > by an NVMe partition e.g. /dev/nvme0n1p1 on s390x.
> > 
> > Signed-off-by: Sam Li <faithilike...@gmail.com>
> > Reviewed-by: Matthew Rosato <mjros...@linux.ibm.com>
> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
> > ---
> >  block/file-posix.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
> 
> We should put this in 8.1 rc2 IMHO

Agreed, I will send a block pull request for 8.1.

Stefan

signature.asc
Description: PGP signature