Re: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check

[Anthony Liguori]

On 02/07/2012 08:09 AM, Markus Armbruster wrote:

Cleaned up silently in commit aad04cd0, but that just got reverted.
Re-apply this part.

Signed-off-by: Markus Armbruster<arm...@redhat.com>

Reviewed-by: Anthony Liguori <aligu...@us.ibm.com>

Regards,

Anthony Liguori

---
  qemu-char.c |    4 ----
  1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index c25863a..bb9e3f5 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1226,10 +1226,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
      }
      tty_serial_init(fd, 115200, 'N', 8, 1);
      chr = qemu_chr_open_fd(fd, fd);
-    if (!chr) {
-        close(fd);
-        return NULL;
-    }
      chr->chr_ioctl = tty_serial_ioctl;
      chr->chr_close = qemu_chr_close_tty;
      return chr;