On Fri, 10 Feb 2012 12:30:21 +0100 Gerd Hoffmann <kra...@redhat.com> wrote:
> On 02/07/12 15:38, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" <berra...@redhat.com> > > > > This is a followup to > > > > http://patchwork.ozlabs.org/patch/121004/ > > > > With the acceptance of some new APIs to libspice-server.so it > > is possible to add support for SPICE to the 'add_client' > > monitor command, bringing parity with VNC. Since SPICE can > > use TLS or plain connections, the command also gains a new > > 'tls' parameter to specify whether TLS should be attempted > > on the injected client sockets. > > > > This new feature is only enabled if building against a > > libspice-server >= 0.10.1 > > > > * qmp-commands.hx: Add 'tls' parameter & missing doc for > > 'skipauth' parameter > > * monitor.c: Wire up SPICE for 'add_client' command > > * ui/qemu-spice.h, ui/spice-core.c: Add qemu_spice_display_add_client > > API to wire up from monitor > > Spice bits are sane, the monitor bits look good to me too. > > Luiz? Can you have a look at the monitor bits? If you ack I'll go > queue it up for the next spice update. Or you can just grab it and > merge via qmp tree. Reviewed. Will need a respin. Will ack v3 and you merge it through the spice queue.
