On 6/8/2023 3:40 PM, Igor Mammedov wrote:
On Wed, 7 Jun 2023 15:57:16 -0500 Suravee Suthikulpanit<suravee.suthikulpa...@amd.com> wrote:Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully supported since QEMU 7.0, default to use SMBIOS 3.0 for newer machine models. This is necessary to avoid the following message when launching a VM with large number of vcpus. "SMBIOS 2.1 table length 66822 exceeds 65535" Signed-off-by: Suravee Suthikulpanit<suravee.suthikulpa...@amd.com>Looks good to me (see comment below for extra cleanup possibility): Reviewed-by: Igor Mammedov<imamm...@redhat.com>--- hw/i386/pc.c | 4 +++- hw/i386/pc_piix.c | 5 +++++ hw/i386/pc_q35.c | 5 +++++ include/hw/i386/pc.h | 1 + 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index bb62c994fa..33ffb03a32 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1853,6 +1853,7 @@ static void pc_machine_set_max_fw_size(Object *obj, Visitor *v, static void pc_machine_initfn(Object *obj) { PCMachineState *pcms = PC_MACHINE(obj); + PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(pcms);since you introduce this local, I suggest you to post an extra clean up patch on top of this series here is a line to cleanup with 'pcmc' /* acpi build is enabled by default if machine supports it */ pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
Sure just sent out the "[PATCH] hw/i386/pc: Clean up pc_machine_initfn". Thanks, Suravee
