v3 was here: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg03607.html
Since then, I've incorporated lots of feedback from Vladimir: - split several patches into smaller pieces - use an enum to track various negotiation modes - reorder a few patches - several new patches (2, 5, 6) - other cleanups 001/24:[----] [--] 'nbd/client: Use smarter assert' 002/24:[down] 'nbd: Consistent typedef usage in header' 003/24:[0137] [FC] 'nbd/server: Prepare for alternate-size headers' 004/24:[0093] [FC] 'nbd/server: Refactor to pass full request around' 005/24:[down] 'nbd: s/handle/cookie/ to match NBD spec' 006/24:[down] 'nbd/client: Simplify cookie vs. index computation' 007/24:[----] [-C] 'nbd/client: Add safety check on chunk payload length' 008/24:[down] 'nbd: Use enum for various negotiation modes' 009/24:[down] 'nbd: Replace bool structured_reply with mode enum' 010/24:[down] 'nbd/client: Pass mode through to nbd_send_request' 011/24:[0096] [FC] 'nbd: Add types for extended headers' 012/24:[0118] [FC] 'nbd: Prepare for 64-bit request effect lengths' 013/24:[0071] [FC] 'nbd/server: Refactor handling of request payload' 014/24:[down] 'nbd/server: Prepare to receive extended header requests' 015/24:[down] 'nbd/server: Prepare to send extended header replies' 016/24:[0132] [FC] 'nbd/server: Support 64-bit block status' 017/24:[down] 'nbd/server: Enable initial support for extended headers' 018/24:[down] 'nbd/client: Plumb errp through nbd_receive_replies' 019/24:[0066] [FC] 'nbd/client: Initial support for extended headers' 020/24:[0032] [FC] 'nbd/client: Accept 64-bit block status chunks' 021/24:[0058] [FC] 'nbd/client: Request extended headers during negotiation' 022/24:[down] 'nbd/server: Refactor list of negotiated meta contexts' 023/24:[0132] [FC] 'nbd/server: Prepare for per-request filtering of BLOCK_STATUS' 024/24:[0109] [FC] 'nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS' Eric Blake (24): nbd/client: Use smarter assert nbd: Consistent typedef usage in header nbd/server: Prepare for alternate-size headers nbd/server: Refactor to pass full request around nbd: s/handle/cookie/ to match NBD spec nbd/client: Simplify cookie vs. index computation nbd/client: Add safety check on chunk payload length nbd: Use enum for various negotiation modes nbd: Replace bool structured_reply with mode enum nbd/client: Pass mode through to nbd_send_request nbd: Add types for extended headers nbd: Prepare for 64-bit request effect lengths nbd/server: Refactor handling of request payload nbd/server: Prepare to receive extended header requests nbd/server: Prepare to send extended header replies nbd/server: Support 64-bit block status nbd/server: Enable initial support for extended headers nbd/client: Plumb errp through nbd_receive_replies nbd/client: Initial support for extended headers nbd/client: Accept 64-bit block status chunks nbd/client: Request extended headers during negotiation nbd/server: Refactor list of negotiated meta contexts nbd/server: Prepare for per-request filtering of BLOCK_STATUS nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS docs/interop/nbd.txt | 1 + include/block/nbd.h | 201 ++++-- nbd/nbd-internal.h | 8 +- block/nbd.c | 189 +++-- nbd/client-connection.c | 4 +- nbd/client.c | 199 ++++-- nbd/common.c | 29 +- nbd/server.c | 666 ++++++++++++------ qemu-nbd.c | 8 +- block/trace-events | 1 + nbd/trace-events | 29 +- tests/qemu-iotests/223.out | 18 +- tests/qemu-iotests/233.out | 4 + tests/qemu-iotests/241.out | 3 + tests/qemu-iotests/307.out | 15 +- .../tests/nbd-qemu-allocation.out | 3 +- 16 files changed, 937 insertions(+), 441 deletions(-) base-commit: 4f65e89f8cf0e079b4ec3ddfede314bbb4e35c76 -- 2.40.1
