On 7 February 2012 22:07, Andreas Färber <afaer...@suse.de> wrote:
> Am 07.02.2012 20:06, schrieb Peter Maydell:
>> On 7 February 2012 18:41, Andreas Färber <afaer...@suse.de> wrote:
>>> Andrzej will have had his reasons to put it in the code. This series
>>> just moves code around so I don't want to remove it without his ack.
>>
>> That was my point -- as far as I can see this patch *is* adding code
>> and a struct field that wasn't there before.
>
> Huh? Look closely, it *was* a comment in the original code.

Exactly. It was a comment; now it's code. I don't think we should
be adding code.

> And I don't want to *move* that comment over into my new code.

You can move the comment, or you can just drop it; I'm happy with
either. I don't want new code/struct fields we don't use.

-- PMM

Reply via email to