On 5/16/23 07:44, Nicholas Piggin wrote:
On Tue May 16, 2023 at 7:32 PM AEST, Daniel Henrique Barboza wrote:
On 5/15/23 06:26, Nicholas Piggin wrote:
A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and
results in hflags mismatch:
qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d)
This can be reproduced by running perf on a recent machine.
Signed-off-by: Nicholas Piggin <npig...@gmail.com>
---
Fixes: c2eff582a32f ("target/ppc: PMU basic cycle count for pseries TCG")
Or is it this one? 0625c7760d54 ("target/ppc: do not call
hreg_compute_hflags() in helper_store_mmcr0()")
Ah, neither! It looks like 8b3d1c49a9f0 ("target/ppc: Add new PMC
HFLAGS"). But that shows I have probably missed HFLAGS_PMC_OTHER
here.
Let me do a bit more investigation and send an updated patch if
necessary.
Sure, let's hold this one for now.
Daniel
Thanks,
Nick
(not sure why I didn't hit this back in 2021)
Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>