On 05/05/2023 14.35, Fabiano Rosas wrote:
On a build configured with: --disable-tcg --enable-xen it is possible to produce a QEMU binary with no TCG nor KVM support. Skip the test if that's the case.Fixes: 0c1ae3ff9d ("tests/qtest: Fix tests when no KVM or TCG are present") Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Fabiano Rosas <faro...@suse.de> --- tests/qtest/cdrom-test.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c index 26a2400181..09655e6ff0 100644 --- a/tests/qtest/cdrom-test.c +++ b/tests/qtest/cdrom-test.c @@ -205,6 +205,11 @@ int main(int argc, char **argv)g_test_init(&argc, &argv, NULL); + if (!qtest_has_accel("tcg") && !qtest_has_accel("kvm")) {+ g_test_skip("No KVM or TCG accelerator available"); + return 0; + }
You only nee to skip the test if running with x86 or s390x, all other targets use only "-accel qtest" IIRC, so those shoul be fine.
Thomas
