v3:
01: add r-bs
02: improve commit message
03: - improve commit message
- drop ifdefs from migration/colo.c which are not needed anymore
- don't move migrate_colo_enabled() (now just migrate_colo()), instead
modify it inplace
- keep colo-compare.c for now (will be handled in updated 04 patch)
- so, no colo_compare_cleanup() stub needed for now, neither
migrate_colo_enabled() stub
- keep Acked-by.
04: - improve commit message
- rename to --disable-colo-proxy to match subsystem name in MAINTAINERS
- don't introduce CONFIG_COLO_PROXY, it actually is not needed
- colo-compare.c is handled now and included if any of 'replication' and
'colo-proxy' are enabled
- so, we add colo_compare_cleanup() stub in a separate stub file
Hi all!
COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
simply don't allow to set x-colo capability in this case. So, let's not
compile in unreachable code and interface we cannot use when
CONFIG_REPLICATION is unset.
Also, provide personal configure option for COLO Proxy subsystem.
Vladimir Sementsov-Ogievskiy (4):
block/meson.build: prefer positive condition for replication
scripts/qapi: allow optional experimental enum values
build: move COLO under CONFIG_REPLICATION
configure: add --disable-colo-proxy option
block/meson.build | 2 +-
hmp-commands.hx | 2 ++
meson_options.txt | 2 ++
migration/colo.c | 28 -------------------------
migration/meson.build | 6 ++++--
migration/migration-hmp-cmds.c | 2 ++
migration/options.c | 17 ++++++++--------
net/meson.build | 14 +++++++++----
qapi/migration.json | 12 +++++++----
scripts/meson-buildoptions.sh | 3 +++
scripts/qapi/types.py | 2 ++
stubs/colo-compare.c | 7 +++++++
stubs/colo.c | 37 ++++++++++++++++++++++++++++++++++
stubs/meson.build | 2 ++
14 files changed, 88 insertions(+), 48 deletions(-)
create mode 100644 stubs/colo-compare.c
create mode 100644 stubs/colo.c
--
2.34.1
