> -----Original Message----- > From: Richard Henderson <richard.hender...@linaro.org> > Sent: Wednesday, April 26, 2023 4:23 PM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > <bc...@quicinc.com>; Matheus Bernardino (QUIC) > <quic_mathb...@quicinc.com> > Subject: Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up > pred_written usage > > On 4/26/23 01:42, Taylor Simpson wrote: > > Only endloop instructions will conditionally write to a predicate. > > When there is an endloop instruction, we preload the values into > > new_pred_value. > > > > The only place pred_written is needed is when HEX_DEBUG is on. > > > > We remove the last use of check_for_attrib. However, new uses will be > > introduced later in this series, so we change it to "static inline". > > This is insufficient -- clang will warn about unused inline functions within > the > main C file (as opposed to #included). > > Use __attribute__((unused)) instead, and remove it when it gains new > unconditional uses.
Is it OK to use the attribute itself or is G_GNUC_UNUSED preferred? > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Thanks, Taylor
